V3 conformant #144
V3 conformant #144
Conversation
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok,
anaxceron and
ATorrise
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #144 +/- ##
==========================================
- Coverage 75.22% 74.48% -0.75%
==========================================
Files 25 24 -1
Lines 331 337 +6
Branches 42 44 +2
==========================================
+ Hits 249 251 +2
- Misses 82 86 +4 ☔ View full report in Codecov by Sentry. |
| }, | ||
| "peerDependencies": { | ||
| "@zowe/imperative": "^5.0.0" | ||
| "@zowe/imperative": ">8.0.0-next.0 <9.0.0" |
There was a problem hiding this comment.
I think we have gone back and forth on this, but curious if the intention is to allow for any 8.x.x (non-prerelease included) to be compatible with this version. 🤔
There was a problem hiding this comment.
Not really, I plan for this to update when we are out of prerelease to be >8.0.0.
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
CHANGELOG.md
Outdated
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| All notable changes to the IBM® Db2® Plug-in for Zowe CLI will be documented in this file. | |||
|
|
|||
| ## Recent Changes | |||
|
|
|||
| - BugFix: Exit code 1 when DB2 calls do not succeed | |||
There was a problem hiding this comment.
We should explain the actual fix for this. Also, this needs a PR/issue link.
There was a problem hiding this comment.
Updated link and wording to state that the command will exit with code 1 if something goes wrong with issuing commands. This tells automation that something went wrong.
CHANGELOG.md
Outdated
| ## Recent Changes | ||
|
|
||
| - BugFix: Exit code 1 when DB2 calls do not succeed | ||
| - V3 Breaking: Updated engines, removed health check and v1 profile support, added port and database to template |
CHANGELOG.md
Outdated
|
|
||
| - BugFix: Exit code 1 when DB2 calls do not succeed | ||
| - V3 Breaking: Updated engines, removed health check and v1 profile support, added port and database to template | ||
|
|
||
| ## `5.0.6` | ||
|
|
||
| - BugFix: Update follow-redirects transitive dependency to resolve technical debt |
| zowe config set profiles.db2.properties.port <port number> | ||
| ``` | ||
|
|
||
| 4. Set the database to your Db2 database: |
There was a problem hiding this comment.
I do not believe database should be two words. It is referenced as database in Zowe Docs.
README.md
Outdated
| zowe config set profiles.db2.properties.database <database name> | ||
| ``` | ||
|
|
||
| 5. If required, set the SSL File to the CA certificate used for the DB2 server |
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
|
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Updates the DB2 plug-in for V3 conformance
How to Test
Review Checklist
I certify that I have:
Additional Comments