Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate VSCE-only functionality to SDKs and CLI plug-in #120

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Mar 24, 2024

What It Does

This PR migrates the functionality listed below from the VSCE does to the SDK and implements the corresponding CLI command. This PR also adds unit tests for the SDK and CLI versions of the migrated functionality. No system tests implemented at this time.

  • Enable transaction
  • Enable program
  • Enable localFile
  • Disable transaction
  • Disable program
  • Disable localFile
  • Open localFile
  • Close localFile
  • PhaseIn program
  • Purge task

How to Test

Run unit tests and execute all corresponding commands

Review Checklist
I certify that I have:

Additional Comments

A new PR will follow with system tests.

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 added the enhancement New feature or request label Mar 24, 2024
@zFernand0 zFernand0 self-assigned this Mar 24, 2024
@zFernand0 zFernand0 linked an issue Mar 24, 2024 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 93.60000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.85%. Comparing base (a46376e) to head (4bf0fc8).
Report is 2 commits behind head on next.

Files Patch % Lines
packages/sdk/src/rest/CicsCmciRestClient.ts 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #120      +/-   ##
==========================================
+ Coverage   93.17%   93.85%   +0.67%     
==========================================
  Files          73       79       +6     
  Lines         718      781      +63     
  Branches       55       58       +3     
==========================================
+ Hits          669      733      +64     
+ Misses         49       48       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…nto feat/sdk-move

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Base automatically changed from next to main September 20, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Release Backlog
Development

Successfully merging this pull request may close these issues.

Migrate VSCE-only commands into the SDK
2 participants