Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hoon root to %k.138 #227

Open
wants to merge 1 commit into
base: status
Choose a base branch
from
Open

bump hoon root to %k.138 #227

wants to merge 1 commit into from

Conversation

drbeefsupreme
Copy link
Contributor

Not sure if there was a particular reason this hadn't been updated, or if nobody had gotten around to doing it yet.

I've confirmed that Nockchain runs fine with this. However, test_sivb_en fails. It currently passes on the status branch.

test jets::lock::aes::tests::test_siva_de ... ok
test jets::lock::aes::tests::test_siva_en ... ok
test jets::lock::aes::tests::test_sivb_de ... ok
memory allocation of test jets::lock::aes::tests::test_sivb_en ... 24ok bytes failed

I spent a few minutes looking into this but nothing popped out at me.

@drbeefsupreme
Copy link
Contributor Author

Hmmm, the test passed on CI. I wonder what's causing it to fail on my machine?

@eamsden
Copy link
Collaborator

eamsden commented Apr 25, 2024

Rather than mutating, this should be copied, or perhaps we should write a const function that takes the kelvin root.

/** Root for Hoon %k.139
/** Root for Hoon %k.138
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need both roots in place, which means the hot state needs to be duplicated. A const function is probably the way here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants