Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool store connections #417

Merged
merged 20 commits into from
Sep 9, 2020
Merged

Pool store connections #417

merged 20 commits into from
Sep 9, 2020

Commits on Sep 1, 2020

  1. Checkpoint on refactoring to better manage store connections. Refs #409… 

    … and refs #390
    @jamadden
    jamadden committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    770c04a View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. The BlobStorer uses the blobhelper and store_connection of the phase.

    @jamadden
    jamadden committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    db9617c View commit details
    Browse the repository at this point in the history

  2. The Loader shouldn't need the store_connection either.

    @jamadden
    jamadden committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    e42853c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Begin pooling the store connection for the storage and its OIDs.

    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8c2a555 View commit details
    Browse the repository at this point in the history

  2. Cant rely on instance state being set by on_store_opened, only connec… 

    …tion/session state.
    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    22aff13 View commit details
    Browse the repository at this point in the history

  3. Minor test fixes

    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    6beb046 View commit details
    Browse the repository at this point in the history

  4. Add support for a maximum number of pooled store connections.

    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    49b159f View commit details
    Browse the repository at this point in the history

  5. Maniuplate the count only inside the lock.

    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    69b6939 View commit details
    Browse the repository at this point in the history

  6. MySQL: Share the locker, mover, and connmanager 

    There's some state that they need, notable supports_row_lock_nowait, that wasn't being set anymore in all cases due to pooling the store connection.
    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    81045ee View commit details
    Browse the repository at this point in the history

  7. checkTL_InterleavedConflictingReadCurrentDeadlock: Don't leave the tr… 

    …ansaction dangling open.
    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    e45ad99 View commit details
    Browse the repository at this point in the history

  8. PostgreSQL: Share the locker, mover, and connmanager. 

    As for MySQL.
    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    dac9505 View commit details
    Browse the repository at this point in the history

  9. Oracle, sqlite: Share the locker, mover and connmanager.

    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    29bf749 View commit details
    Browse the repository at this point in the history

  10. Remove unused arg.

    @jamadden
    jamadden committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    bd829f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Catch a case where using the good commit lock procs on MySQL didn't r… 

    …aise the right error on failure.

e.g., https://travis-ci.org/github/zodb/relstorage/jobs/723935887#L1029

Not clear why we would be raising that error in that test though. I con't reproduce locally, even with a slow database.
    @jamadden
    jamadden committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    a1759e2 View commit details
    Browse the repository at this point in the history

  2. Improve cleanup of resources in SharedTPCState.

    @jamadden
    jamadden committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    962892e View commit details
    Browse the repository at this point in the history

  3. A bit cleaner separation of concerns on cleanup.

    @jamadden
    jamadden committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    dc41c3e View commit details
    Browse the repository at this point in the history

  4. Some unittesting for the new TPC state management.

    @jamadden
    jamadden committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    c822910 View commit details
    Browse the repository at this point in the history

  5. Decouple the blobhelper from TPC if net needed.

    @jamadden
    jamadden committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    dbad2e3 View commit details
    Browse the repository at this point in the history

  6. Comment cleanup.

    @jamadden
    jamadden committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    4564dfa View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Add basic tests for tpc/vote.py

    @jamadden
    jamadden committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    284bd66 View commit details
    Browse the repository at this point in the history