Android: Ensure any audio files that are playing when app exits are stopped & released #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benvium I've resolved the conflicts with master. Do you see any reason not to merge this? |
|
@paulmelnikow Isn't this a bug yet? If yes, could we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that on Android, if you attempt to pause an audio during the
componentWillUnmountmethod of the root component, the pause method of RNSoundModule was never executed. In our case this was because thereact-native-soundmodule was destroyed before the JS -> Java message to pause the audio came through.This PR automatically stops and releases all MediaPlayer instances when React Native shuts down.
In the past, we've had odd exceptions during release of MediaPlayer, so the code below adopts a pretty defensive strategy.
Tested on Android 7.0, 6.0, and 4.4.4.