-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native New Architecture support Done #850
base: master
Are you sure you want to change the base?
Conversation
feat: added fabric example fix: example testing fix: removed unwated scripts feat: new architecture support done
d0c981f
to
313452e
Compare
Delete sound.ts Delete package-lock.json Update RNSound.podspec Update RNSound.podspec Update RNSound.podspec Update RNSound.podspec Update package.json
eedcbfd
to
a408375
Compare
Thank you @SolankiYogesh. I don't currently have time to review & test. If anyone can review it? :) |
Thanks @SolankiYogesh ! These methods are missing for Android.
For iOS while there's
@RomualdPercereau maybe let's consider releasing alpha version with the new arch and ask devs to test it with us. I'll try to run some tests as well |
@Okelm i think both methods are not required because. ok let me check again all code and yes i am currently using this patch in my product app |
ok yes enable method is missing let me add ` ` |
1f68a26
to
e88769c
Compare
As long as there's no plan to ditch Windows support this will require Windows new arch rewrite as well. |
feat: added fabric example
fix: example testing
fix: removed unwated scripts
feat: new architecture support done