fix(storage): Fix histogram storage doesn't clear

zlodes · Jul 5, 2023 · 24f0194 · 24f0194
1 parent 13a1f8b
commit 24f0194
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Storage/InMemoryStorage.php b/src/Storage/InMemoryStorage.php
@@ -37,6 +37,7 @@ public function fetch(): Generator
     public function clear(): void
     {
         $this->simpleMetricsStorage = [];
+        $this->histogramStorage = [];
     }
 
     public function setValue(MetricValue $value): void

diff --git a/src/Storage/StorageTesting.php b/src/Storage/StorageTesting.php
@@ -99,7 +99,19 @@ public function testGetAllAndEmpty(): void
             )
         );
 
-        assertCount(1, $this->fetchList($storage));
+        $storage->persistHistogram(
+            new MetricValue(
+                new MetricNameWithLabels('response_time'),
+                0.5
+            ),
+            [0.1, 0.5, 1]
+        );
+
+        // 1 of cpu_temp gauge
+        // 3 of response_time histogram
+        // 1 +Inf of response_time histogram
+        // 2 (sum and count) of response_time histogram
+        assertCount(7, $this->fetchList($storage));
 
         $storage->clear();
         assertEmpty($this->fetchList($storage));