Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add dist folder with index file #153

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

isidroamv
Copy link
Collaborator

This PR addresses the issue #101 which focuses on enhancing the accessibility of our libraries by adding the dist folder.

Changes Introduced:

  • Add a dist folder for simplified access to compiled code.
  • Add index.ts file in helpers pacakge

Details:

With this pull request, accessing our libraries becomes more straightforward, thanks to the introduction of the dist folder.
Note that I'm not modifying the twitter packages since there is a plan to move them out. See convo #144

With this modification developers can now easily retrieve compiled code, making integration into their projects a smoother process. Example:

import { toCircomBigIntBytes } from "@zk-email/helpers"; instead of
import { toCircomBigIntBytes } from "@zk-email/helpers/src/binaryFormat";

@Divide-By-0
Copy link
Member

@Metachaser24 how does this compare to ur idea?

@Divide-By-0 Divide-By-0 merged commit 5c46156 into zkemail:main Dec 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants