Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up render snippets #324

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Clean up render snippets #324

merged 7 commits into from
Jan 11, 2024

Commits on Dec 13, 2023

  1. Clean up render_snippets

    @LHolten
    LHolten committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d4f30ec View commit details
    Browse the repository at this point in the history

  2. Choose primary label from inside the context

    @LHolten
    LHolten committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    997a3ea View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Revert to passing around SpanContents

    @LHolten
    LHolten committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0bf3dae View commit details
    Browse the repository at this point in the history

  2. Add test for triple label context

    @LHolten
    LHolten committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    36f7f65 View commit details
    Browse the repository at this point in the history

  3. use std::cmp::max instead of manual calculation

    @LHolten
    LHolten committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b1e2bd2 View commit details
    Browse the repository at this point in the history

  4. Update test so that it finds the bug. 

    The previous test would still have overlap between the first and last context because of contexts are extended with `context_lines`.
    @LHolten
    LHolten committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5fda9b0 View commit details
    Browse the repository at this point in the history

  5. Add test for non adjacent contexts

    @LHolten
    LHolten committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e16326a View commit details
    Browse the repository at this point in the history