ppc: support 32bit AIX and OSX #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenas
force-pushed
the
aix32
branch
2 times, most recently
from
8bd033e
to
e26ec11
Compare
Since c0270dc (Support floating point arguments by more ABIs., 2017-10-21) tests had been failing in 32bit AIX, because the ABI it uses is slightly different than the one implemented. Reuse the 64bit implementation for 32bit AIX, but add the ability to skip two 32bit general registers for each 64bit floating point argument. To support a fourth argument when all three previous ones are doubles r9 had to be make accessible as a scratch register, so add r11 to replace it as TMP_REG1, with the caveat it might be clobbered by inter module calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem in 32bit AIX, where functions using doubles will fail to map correctly their function parameters.
Tested in AIX, Linux and OSX (thanks to @sevan)
Using
r11for TMP_REG1 might be controversial, but seem safe in practice, with the caveat that it wouldn't be preserved around inter module calls.There is also the possibility this change might be needed for other systems (ex: BSD), althought NetBSD/macppc and and older OpenBSD 6.6 seems to work (at least in 32bit) without it.