Minor build performance improvements #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there's some overhead for the function call, we end up getting SIMD memchr for free. We could write our own SIMD function here but memchr ends up being very cheap.
When buildAppendFilePart is called with chunk data as the source we need to copy it as the lifetimes are decoupled; however for changed files, we've already allocated a vector for it so it's a waste to copy it as we can move instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux kernel source tree with 16 workers, this gets total wall clock time for
qgrep builddown from 1.36s to 1.21s, although timing is noisy; both operations are done on the main thread so this effectively reduces the serialization.