Upgrade proposals: estimated upgrade time #507
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (1)
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces a new dependency, Moment.js, to the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@CharlieMc0 added "Estimated upgrade time" estimated based on 5.5 s block time. Anything else we want to see from Polkachu's table? |
fadeev
requested review from
bbbeeeee,
brewmaster012 and
a team
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (4)
package.json (1)
58-58: Pin the dependency versionIf moment.js must be retained, consider pinning its version to avoid unexpected breaking changes:
- "moment": "^2.30.1", + "moment": "2.30.1",This aligns with the versioning strategy used for other dependencies in the project.
src/components/Docs/components/GovUpgradeProposals.tsx (3)
9-16: Refactor API endpoints configurationThe API endpoints contain duplicated URL patterns and could benefit from a more maintainable structure.
const API_CONFIG = { testnet: { baseUrl: 'https://zetachain-athens', providers: { allthatnode: '.g.allthatnode.com/archive/rest', blockpi: '.blockpi.network/lcd/v1/public' } }, mainnet: { baseUrl: 'https://zetachain', providers: { allthatnode: '.g.allthatnode.com/archive/rest', blockpi: '.blockpi.network/lcd/v1/public' } } }; const buildUrl = (network: NetworkType, provider: string, path: string) => `${API_CONFIG[network].baseUrl}${API_CONFIG[network].providers[provider]}${path}`;
Line range hint
70-98: Improve type safety and error handling in proposal fetchingThe current implementation uses
anytypes extensively and could benefit from proper TypeScript interfaces and more user-friendly error handling.interface UpgradePlan { name: string; height: number; info: string; } interface Proposal { status: string; messages: Array<{ '@type': string; plan?: UpgradePlan; }>; } const transformProposal = (proposal: Proposal) => { const plan = proposal.messages.find(msg => msg['@type'].includes('MsgSoftwareUpgrade'))?.plan; if (!plan) return null; return { ...proposal, plan, status: proposal.status .replace('PROPOSAL_STATUS_', '') .replace(/_/g, ' ') .toLowerCase() }; }; const fetchProposals = async () => { try { const response = await fetch(API_PROPOSALS[activeTab.networkType]); const data = await response.json(); if (!data?.proposals) { throw new Error('Invalid response format'); } const upgrades = data.proposals .map(transformProposal) .filter(Boolean) .sort((a, b) => b.plan.height - a.plan.height); return upgrades; } catch (error) { console.error('Error:', error); throw new Error('Failed to fetch upgrade proposals'); } };
Line range hint
137-148: Enhance UI feedback for time estimatesConsider adding loading and error states for the time estimates to improve user experience.
<td> {latestBlock === 0 ? ( <span className="text-gray-400">Loading...</span> ) : ( calculateUpgradeTime(proposal.plan.height) )} </td>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
package.json(2 hunks)src/components/Docs/components/GovUpgradeProposals.tsx(6 hunks)
Co-authored-by: Guillermo Maiolo <guille.maiolo@gmail.com>
Summary by CodeRabbit