bugfix: Fix Temporary Containers Automatic mode | change firefox -> zen for default cookiestore id

[lbrooney]

Closes #172

This PR fixes automatic mode for Temporary Containers by patching firefox-default to zen-default. I also included changes to the other store names to maintain consistency.

Based off brief testing this does not impact Workspaces. The default container of a workspace takes precedence over an automatic container.

I can't comment whether this fix breaks other container extensions. If they hardcoded checking cookieStoreId against firefox-default, then this fix would break them.

Why temporary containers didn't work

Inspecting the Temporary Containers extension and then opening a new tab, you will notice an uncaught error from showOrHide caused by L4943.

Examining Temporary Containers source code, showOrHide is found in pageaction.ts with the line causing the throw at L43. The correct behaviour is the if else on L31 executing, not the else.

In Zen that if else doesn't execute because Temporary Container assumes the default cookieStoreId is the browser's name (zen) appended with -default. However the default cookiestore id is set to firefox-default. Thus the else if doesn't execute as zen-default does not equal firefox-default and the extension proceeds to the else causing the error.

[mr-cheff]

Id have to investigate this, as idk if it'll log out of all session for all users updating

[lbrooney]

Based off a quick test, when using the tab without a container, I don't get logged out of accounts when I change from firefox-default to zen-default and vice versa. This was done in the dev environment. Also doesn't affect the session status in other containers. Excited to hear your results!

[lbrooney]

Hi,
Just wondering if there were anything blocking this from being merged? If there's something I can do to help out or speed it along I'm willing to contribute.

Thanks for all your hard work!

[lbrooney]

This PR would break Simple Tab Groups automatic temporary container functionality as it checks against firefox-default