Additions needed for Orchard batch scanning #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
- Coverage 80.64% 80.59% -0.06%
==========================================
Files 30 30
Lines 3152 3154 +2
==========================================
Hits 2542 2542
- Misses 610 612 +2 ☔ View full report in Codecov by Sentry. |
str4d
changed the title
impl subtle::ConstantTimeEq for note::Nullifier
str4d
approved these changes
Feb 26, 2024
Comment on lines
+11
to
+13
| - `impl subtle::ConstantTimeEq for note::Nullifier` | ||
| - `impl Clone for note_encryption::CompactAction` | ||
| - `note_encryption::CompactAction::cmx` |
There was a problem hiding this comment.
Suggested change
| - `impl subtle::ConstantTimeEq for note::Nullifier` | |
| - `impl Clone for note_encryption::CompactAction` | |
| - `note_encryption::CompactAction::cmx` | |
| - `impl subtle::ConstantTimeEq for orchard::note::Nullifier` | |
| - `orchard::note_encryption`: | |
| - `impl Clone for CompactAction` | |
| - `CompactAction::cmx` |
There was a problem hiding this comment.
I'll do this in the release PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.