unused import: `H`

usage of `Iterator::fold` on a type that implements `Try`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

usage of `Iterator::fold` on a type that implements `Try`

usage of `Iterator::fold` on a type that implements `Try`

10 warnings emitted

warning: unused import: `H` --> src/constants.rs:6:91 | 6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H}; | ^ | = note: `#[warn(unused_imports)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:533:14 | 533 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/builder.rs:614:18 | 614 | .zip(indexed_outputs.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/f2043422f7b161a2fc1a00589a8c4956db963450/library/core/src/iter/traits/iterator.rs:643:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:637:10 | 637 | .fold(Some(ValueSum::zero()), |acc, action| { | __________^ 638 | | acc? + action.value_sum() 639 | | }) | |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: function cannot return without recursing --> src/keys.rs:174:5 | 174 | / fn eq(&self, other: &Self) -> bool { 175 | | <[u8; 32]>::from(&self.0).eq(&<[u8; 32]>::from(&other.0)) 176 | | } | |_____^ | note: recursive call site --> src/keys.rs:175:9 | 175 | <[u8; 32]>::from(&self.0).eq(&<[u8; 32]>::from(&other.0)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion = note: `#[warn(clippy::unconditional_recursion)]` on by default

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption.rs:246:18 | 246 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/f2043422f7b161a2fc1a00589a8c4956db963450/library/core/src/iter/traits/iterator.rs:643:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: function cannot return without recursing --> src/primitives/redpallas.rs:95:5 | 95 | / fn eq(&self, other: &Self) -> bool { 96 | | <[u8; 32]>::from(self).eq(&<[u8; 32]>::from(other)) 97 | | } | |_____^ | note: recursive call site --> src/primitives/redpallas.rs:96:9 | 96 | <[u8; 32]>::from(self).eq(&<[u8; 32]>::from(other)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/primitives/redpallas.rs:102:1 | 102 | / impl<T: SigType> PartialOrd for VerificationKey<T> { 103 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 104 | || <[u8; 32]>::from(self).partial_cmp(&<[u8; 32]>::from(other)) 105 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 106 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:195:14 | 195 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold