This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Fixing the docker images filter issue with ListImagesParam.byName method in getLatestDownloadedImage method #1244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR
quickly.
Description
DockerClient.ListImagesParam.byName method was not filtering the images based on the image name. Rather it was giving all available docker images in system which in turn returns the first available image from the
getLatestDownloadedImage
method from theDockerContainerClient
file. I have used java filtering to solve this issue.Motivation and Context
As getLatestDownloadedImage method was return wrong image name, zalenium was starting the wrong container.
How Has This Been Tested?
I have tested these changes locally as well as on our servers, which after the changes works perfectly fine.
Types of changes
Checklist: