Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Fixing the docker images filter issue with ListImagesParam.byName method in getLatestDownloadedImage method #1244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pr-prashant
Copy link

@pr-prashant pr-prashant commented Sep 11, 2021

Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR
quickly.

Description

DockerClient.ListImagesParam.byName method was not filtering the images based on the image name. Rather it was giving all available docker images in system which in turn returns the first available image from the getLatestDownloadedImage method from the DockerContainerClient file. I have used java filtering to solve this issue.

Motivation and Context

As getLatestDownloadedImage method was return wrong image name, zalenium was starting the wrong container.

How Has This Been Tested?

I have tested these changes locally as well as on our servers, which after the changes works perfectly fine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ch actually picking the first available image in repository. Using java filter to filter the docker images by name.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants