setOptions must honor the type of option param, close #11

yriveiro · Apr 25, 2018 · 166cd27 · 166cd27
1 parent 1682501
commit 166cd27
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 19 deletions.
diff --git a/src/Backoff.php b/src/Backoff.php
@@ -50,12 +50,8 @@ public static function getDefaultOptions() : array
      *
      * @return BackoffInterface
      */
-    public function setOptions($options) : BackoffInterface
+    public function setOptions(array $options) : BackoffInterface
     {
-        if (!is_array($options)) {
-            $options = [$options];
-        }
-
         $this->options = array_merge($this->options, $options);
 
         return $this;

diff --git a/tests/BackoffTest.php b/tests/BackoffTest.php
@@ -94,22 +94,16 @@ public function testSetOptions()
         $this->assertEquals($expected, $options->getValue($this->backoff));
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     */
     public function testSetOptionsNotAnArray()
     {
-        $options = 10;
-
-        $this->backoff->setOptions($options);
-
-        $options = new ReflectionProperty($this->backoff, 'options');
-        $options->setAccessible(true);
-
-        $expected = array(
-            0 => 10,
-            'cap' => 1000000,
-            'maxAttempts' => 0
-        );
-
-        $this->assertEquals($expected, $options->getValue($this->backoff));
+        try {
+            $this->backoff->setOptions(10);
+        } catch (TypeError $e) {
+            throw new InvalidArgumentException();
+        }
     }
 
     /**