Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-505 : Modal > Allow the user to define their own modal footer [vue3] #427

Merged
merged 7 commits into from
Nov 20, 2024
Merged

UI-505 : Modal > Allow the user to define their own modal footer [vue3] #427

merged 7 commits into from
Nov 20, 2024

Conversation

achaaoui-yc
Copy link
Contributor

@achaaoui-yc achaaoui-yc commented Nov 19, 2024 •
edited
Loading

JIRA Ticket

UI-505

QA Steps

QA Steps

  • Run pnpm run dev.
  • See the opened dev preview.
  • See the modal footer is a custom one.

Note

@achaaoui-yc achaaoui-yc added the ⏳ in progress Still in development phase. label Nov 19, 2024
@achaaoui-yc achaaoui-yc self-assigned this Nov 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

🔍 Visual review for your branch is published 🔍

Here are the links to:

@achaaoui-yc achaaoui-yc changed the title UI-505 : Modal > Allow the user to define their own modal footer UI-505 : Modal > Allow the user to define their own modal footer [vue3] Nov 19, 2024
@achaaoui-yc achaaoui-yc added 💻 Ready for review Requires a review from another developer. and removed ⏳ in progress Still in development phase. labels Nov 20, 2024
eihabkhan1
eihabkhan1 requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@eihabkhan1 eihabkhan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR Ayoub! Good stuff 👍

packages/vue3/src/components/Modal/Modal.vue Outdated Show resolved Hide resolved
packages/vue3/src/components/Modal/Modal.vue Outdated Show resolved Hide resolved
@eihabkhan1 eihabkhan1 added 🛠 Requested changes Reviewer asked for some changes to be made. and removed 💻 Ready for review Requires a review from another developer. labels Nov 20, 2024
@eihabkhan1 eihabkhan1 added ✅ Reviewed PR has been reviewed and approved. and removed 🛠 Requested changes Reviewer asked for some changes to be made. labels Nov 20, 2024
@achaaoui-yc achaaoui-yc merged commit c4a2c49 into main Nov 20, 2024
2 checks passed
@achaaoui-yc achaaoui-yc deleted the UI-505 branch November 20, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eihabkhan1 eihabkhan1 eihabkhan1 approved these changes

Assignees

@achaaoui-yc achaaoui-yc

Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achaaoui-yc @eihabkhan1