Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YSHOP2-1294: Update storybook #249

Merged
merged 5 commits into from
Jan 25, 2024
Merged

YSHOP2-1294: Update storybook #249

merged 5 commits into from
Jan 25, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Jan 25, 2024 •
edited
Loading

JIRA Ticket

YSHOP2-1294

QA Steps

  • Check code

Note

Leave empty when you have nothing to say

@eihabkhan1 eihabkhan1 added the ⏳ in progress Still in development phase. label Jan 25, 2024
@eihabkhan1 eihabkhan1 self-assigned this Jan 25, 2024
@eihabkhan1 eihabkhan1 added 💻 Ready for review Requires a review from another developer. and removed ⏳ in progress Still in development phase. labels Jan 25, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review January 25, 2024 14:01
mosarabi
mosarabi suggested changes Jan 25, 2024
View reviewed changes
packages/vue3/.storybook/main.ts Outdated
},
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@mosarabi mosarabi added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Jan 25, 2024
@eihabkhan1 eihabkhan1 merged commit ac4399f into main Jan 25, 2024
1 check passed
@eihabkhan1 eihabkhan1 deleted the YSHOP2-1294 branch January 25, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosarabi mosarabi mosarabi approved these changes

@AliHMIMS AliHMIMS Awaiting requested review from AliHMIMS

@GhitaNektt GhitaNektt Awaiting requested review from GhitaNektt

Assignees

@eihabkhan1 eihabkhan1

Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan1 @mosarabi