-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode, i18n, Dockerfile, resource bar #80
Draft
pratclot
wants to merge
17
commits into
ymichael:main
Choose a base branch
from
pratclot:improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync language with accept-language header data
@pratclot is attempting to deploy a commit to the myel Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks! What an amazing job you have done with the project!
I play for a week, initially wanted to add dark mode only because light mode gives me dry eyes :) I used
next-themes
to make it work, no logic was added from my side.During the game I also needed to scroll around to sync my brain with the game state, in particular to know how many resources I had etc. PC games I played use an always visible "resource bar" for these, so I thought to add something like that. To keep it simple, I just copied the contents of
Players
component. In order to do that I had to break it into explicit components. This job was done by Gemini :)Then I saw i18n issue and decided to give it a hand. I used
next-i18next
to manage translations themselves, and added a rather crude middleware to choose between locales. It will always redirect clients according toaccept-language
. I chose this implementation because game creators currently need to share game links with players and they have no knowledge which language the players prefer. To parse the header I used the same codenext
uses internally, just copied their implementation as-is :)Translation works by looking up literal strings used in game models, no logic there. There is no plurals or context support. The card overview page was really helpful to track strings on cards.
I host my own instance in k8s, so added a simple Dockerfile to create images.
I ignored the tests completely lol, let's add them if you think they are relevant.
Sorry for the huge PR!