Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode, i18n, Dockerfile, resource bar #80

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

pratclot
Copy link

Hey folks! What an amazing job you have done with the project!

I play for a week, initially wanted to add dark mode only because light mode gives me dry eyes :) I used next-themes to make it work, no logic was added from my side.

During the game I also needed to scroll around to sync my brain with the game state, in particular to know how many resources I had etc. PC games I played use an always visible "resource bar" for these, so I thought to add something like that. To keep it simple, I just copied the contents of Players component. In order to do that I had to break it into explicit components. This job was done by Gemini :)

Then I saw i18n issue and decided to give it a hand. I used next-i18next to manage translations themselves, and added a rather crude middleware to choose between locales. It will always redirect clients according to accept-language. I chose this implementation because game creators currently need to share game links with players and they have no knowledge which language the players prefer. To parse the header I used the same code next uses internally, just copied their implementation as-is :)

Translation works by looking up literal strings used in game models, no logic there. There is no plurals or context support. The card overview page was really helpful to track strings on cards.

I host my own instance in k8s, so added a simple Dockerfile to create images.

I ignored the tests completely lol, let's add them if you think they are relevant.

Sorry for the huge PR!

Copy link

vercel bot commented Oct 27, 2024

@pratclot is attempting to deploy a commit to the myel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant