Remove $db property from constructor
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tigrov
commented
Jun 28, 2024
Tigrov
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Fixed issues | #364 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
============================================
- Coverage 86.35% 86.02% -0.33%
- Complexity 597 601 +4
============================================
Files 14 16 +2
Lines 1407 1410 +3
============================================
- Hits 1215 1213 -2
- Misses 192 197 +5 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Jun 30, 2024
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
# Conflicts: # src/AbstractActiveRecord.php # src/ActiveQuery.php # src/ActiveRecordFactory.php # tests/ActiveQueryTest.php # tests/ActiveRecordFactoryTest.php # tests/Stubs/ActiveRecord/CustomerWithConstructor.php
samdark
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.