#1359, Admin UI: return empty relation when filter by invalid Remote IP #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanov-Anton
changed the title
Ivanov-Anton
force-pushed
the
YETIWEB-improve-remote-ip-filter-on-the-api-log-page
branch
from
c6f8385
to
88648a8
Compare
Ivanov-Anton
requested review from
dmitry-sinina and
gigorok
and removed request for
gigorok and
dmitry-sinina
Ivanov-Anton
force-pushed
the
YETIWEB-improve-remote-ip-filter-on-the-api-log-page
branch
from
88648a8
to
182bac1
Compare
…lid remote_ip On the "Logs"->"Api Logs" index page we have a "Remote IP" filter, and when the User filters with invalid IP something like "127.0.0." then the YETI app returns a 500 error which is wrong. In such a case I suggest returning an empty relation in this case.
Ivanov-Anton
force-pushed
the
YETIWEB-improve-remote-ip-filter-on-the-api-log-page
branch
from
182bac1
to
1fec27c
Compare
Ivanov-Anton
changed the title
Ivanov-Anton
deleted the
YETIWEB-improve-remote-ip-filter-on-the-api-log-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the Logs->Api Logs index page we have "Remote IP" filter and when User filter using invalid IP somethink like "127.0.0." then YETI app returns 500 error which is wrong. I suggest to return empty relation in this case.
Additional links
closes #1359