fix reports CSV downloading (#1339)

* fix reports CSV downloading
yeti-switch · Sep 16, 2023 · d07f19c · d07f19c
1 parent a2b932f
commit d07f19c
Show file tree

Hide file tree

Showing 4 changed files with 65 additions and 5 deletions.
diff --git a/app/admin/reports/customer_traffic_data_by_destinations.rb b/app/admin/reports/customer_traffic_data_by_destinations.rb
@@ -22,8 +22,24 @@ def scoped_collection
     end
   end
 
+  # TODO use dedicated decorators for CSV data or show measurement units in header
   csv do
-    parent.csv_columns_by_destination.map { |c| column c }
+    column :destination_prefix
+    column :country
+    column :network
+    column :calls_count
+    column :success_calls_count
+    column :short_calls_count
+    column :calls_duration
+    column :customer_calls_duration
+    column :vendor_calls_duration
+    column :asr
+    column :acd
+    column :origination_cost
+    column :termination_cost
+    column :profit
+    column :first_call_at
+    column :last_call_at
   end
 
   action_item :by_vendors, only: :index do

diff --git a/app/admin/reports/customer_traffic_data_by_vendors.rb b/app/admin/reports/customer_traffic_data_by_vendors.rb
@@ -19,8 +19,22 @@ def scoped_collection
     end
   end
 
+  # TODO use dedicated decorators for CSV data or show measurement units in header
   csv do
-    parent.csv_columns.map { |c| column c }
+    column :vendor
+    column :calls_count
+    column :success_calls_count
+    column :short_calls_count
+    column :calls_duration
+    column :customer_calls_duration
+    column :vendor_calls_duration
+    column :asr
+    column :acd
+    column :origination_cost
+    column :termination_cost
+    column :profit
+    column :first_call_at
+    column :last_call_at
   end
 
   action_item :by_destinations, only: :index do

diff --git a/app/admin/reports/customer_traffic_data_fulls.rb b/app/admin/reports/customer_traffic_data_fulls.rb
@@ -15,9 +15,25 @@ def scoped_collection
     end
   end
 
-  # TODO: fix CSV
+  # TODO use dedicated decorators for CSV data or show measurement units in header
   csv do
-    parent.csv_columns_full.map { |c| column c }
+    column :destination_prefix
+    column :vendor
+    column :country
+    column :network
+    column :calls_count
+    column :success_calls_count
+    column :short_calls_count
+    column :calls_duration
+    column :customer_calls_duration
+    column :vendor_calls_duration
+    column :asr
+    column :acd
+    column :origination_cost
+    column :termination_cost
+    column :profit
+    column :first_call_at
+    column :last_call_at
   end
 
   # TODO: move items + sidebar to act_as_blabla

diff --git a/app/admin/reports/vendor_traffic_data.rb b/app/admin/reports/vendor_traffic_data.rb
@@ -19,8 +19,22 @@ def scoped_collection
     end
   end
 
+  # TODO use dedicated decorators for CSV data or show measurement units in header
   csv do
-    parent.csv_columns.map { |c| column c }
+    column :customer
+    column :calls_count
+    column :success_calls_count
+    column :short_calls_count
+    column :calls_duration
+    column :customer_calls_duration
+    column :vendor_calls_duration
+    column :asr
+    column :acd
+    column :origination_cost
+    column :termination_cost
+    column :profit
+    column :first_call_at
+    column :last_call_at
   end
 
   sidebar 'Vendor traffic report', priority: 0, only: :index do