push #89 rollback

yegor256 · Jul 12, 2024 · 1bd49b2 · 1bd49b2
1 parent 4b5e498
commit 1bd49b2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/pgtk/pool.rb b/lib/pgtk/pool.rb
@@ -124,9 +124,14 @@ def transaction
     connect do |c|
       t = Txn.new(c, @log)
       t.exec('START TRANSACTION')
-      r = yield t
-      t.exec('COMMIT')
-      r
+      begin
+        r = yield t
+        t.exec('COMMIT')
+        r
+      rescue StandardError => e
+        t.exec('ROLLBACK')
+        raise e
+      end
     end
   end
 

diff --git a/test/test_pool.rb b/test/test_pool.rb
@@ -101,6 +101,8 @@ def test_transaction_with_error
         end
       end
       assert(pool.exec('SELECT * FROM book').empty?)
+      pool.exec('INSERT INTO book (title) VALUES ($1)', ['another'])
+      assert(!pool.exec('SELECT * FROM book').empty?)
     end
   end