Rubocop style corrections

yast · Apr 17, 2024 · 75cd78b · 75cd78b
1 parent 586abc1
commit 75cd78b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 19 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -15,6 +15,9 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 14
 
+Metrics/BlockLength:
+  Max: 35
+
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/MethodLength:

diff --git a/src/lib/ydocker/changes_dialog.rb b/src/lib/ydocker/changes_dialog.rb
@@ -48,14 +48,13 @@ def close_dialog
     end
 
     def controller_loop
-      loop do
-        input = Yast::UI.UserInput
-        case input
-        when :ok, :cancel
-          return :ok
-        else
-          raise "Unknown action #{input}"
-        end
+      # no need to loop, one shot is enough
+      input = Yast::UI.UserInput
+      case input
+      when :ok, :cancel
+        :ok
+      else
+        raise "Unknown action #{input}"
       end
     end
 

diff --git a/src/lib/ydocker/inject_shell_dialog.rb b/src/lib/ydocker/inject_shell_dialog.rb
@@ -50,17 +50,15 @@ def close_dialog
     end
 
     def controller_loop
-      loop do
-        input = Yast::UI.UserInput
-        case input
-        when :ok
-          attach
-          return
-        when :cancel
-          return
-        else
-          raise "Unknown action #{input}"
-        end
+      # no need to loop, one shot is enough
+      input = Yast::UI.UserInput
+      case input
+      when :ok
+        attach
+      when :cancel
+        nil
+      else
+        raise "Unknown action #{input}"
       end
     end