Skip to content

Commit

Permalink
Merge pull request #88 from scabrero/SLE-12-SP5
Browse files Browse the repository at this point in the history 
Section name is 'domain_realm' not 'domain_realms'
  • Loading branch information
@dmulder
dmulder authored Mar 11, 2020
2 parents 0a7999d + 4684a47 commit 68f8ee1
Show file tree
Hide file tree
Showing 7 changed files with 66 additions and 26 deletions.
6 changes: 6 additions & 0 deletions package/yast2-auth-client.changes
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Tue Mar 10 10:03:54 UTC 2020 - Samuel Cabrero <scabrero@suse.de>

- yast auth-client and krb5.conf wrong domain_realm entry; (bsc#1122026)
- 3.3.20

-------------------------------------------------------------------
Thu Jan 30 09:57:03 UTC 2020 - Samuel Cabrero <scabrero@suse.de>

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-auth-client.spec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@


Name: yast2-auth-client
Version: 3.3.19
Version: 3.3.20
Release: 0
Url: https://github.com/yast/yast-auth-client
Summary: YaST2 - Centralised System Authentication Configuration
Expand Down
10 changes: 5 additions & 5 deletions src/lib/auth/authconf.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class AuthConf
# Clear all configuration objects.
def clear
# Kerberos configuration
@krb_conf = {'include' => [], 'libdefaults' => {}, 'realms' => {}, 'domain_realms' => {}, 'logging' => {}}
@krb_conf = {'include' => [], 'libdefaults' => {}, 'realms' => {}, 'domain_realm' => {}, 'logging' => {}}
@krb_pam = false
# LDAP configuration (/etc/ldap.conf)
@ldap_conf = {}
Expand Down Expand Up @@ -674,7 +674,7 @@ def krb_import(exported_conf)

# Make sure the Kerberos configuration has all the necessary keys.
def krb_lint_conf
['libdefaults', 'realms', 'domain_realms', 'logging'].each { |key|
['libdefaults', 'realms', 'domain_realm', 'logging'].each { |key|
@krb_conf[key] = {} if @krb_conf[key].nil?
}
@krb_conf['include'] = [] if @krb_conf['include'].nil?
Expand Down Expand Up @@ -794,10 +794,10 @@ def krb_add_update_realm(realm_name, kdc_addr, admin_addr, make_domain_realms, m
end
@krb_conf['realms'][realm_name].merge!("kdc" => kdc_addr, "admin_server" => admin_addr)
if make_domain_realms
@krb_conf['domain_realms'].merge!(".#{realm_name.downcase}" => realm_name, "#{realm_name.downcase}" => realm_name)
@krb_conf['domain_realm'].merge!(".#{realm_name.downcase}" => realm_name, "#{realm_name.downcase}" => realm_name)
else
@krb_conf['domain_realms'].delete(".#{realm_name.downcase}")
@krb_conf['domain_realms'].delete("#{realm_name.downcase}")
@krb_conf['domain_realm'].delete(".#{realm_name.downcase}")
@krb_conf['domain_realm'].delete("#{realm_name.downcase}")
end
if make_default || @krb_conf['libdefaults']['default_realm'].to_s == ''
@krb_conf['libdefaults']['default_realm'] = realm_name
Expand Down
12 changes: 11 additions & 1 deletion src/lib/auth/krbparse.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def self.parse(krb_conf_text)
long_attr1 = ''
long_attr2 = ''
sect = ''
new_krb_conf = {'include' => [], 'libdefaults' => {}, 'realms' => {}, 'domain_realms' => {}, 'logging' => {}}
new_krb_conf = {'include' => [], 'libdefaults' => {}, 'realms' => {}, 'domain_realm' => {}, 'logging' => {}}
# Break down sections and key-value pairs
krb_conf_text.split(/\n/).each{ |line|
# Throw away comment
Expand All @@ -45,6 +45,16 @@ def self.parse(krb_conf_text)
if sect_match
# remember current section
sect = sect_match[1]
# Bug 1122026: krb5.conf sections can have a variable amount
# of characters appended to the name, and still be valid.
# domain_realm for example could have an 's' appended, but
# is not the documented section title.
new_krb_conf.each { |k, v|
if sect_match[1].start_with?(k)
sect = k
break
end
}
next
end
# Remember expanded attribute
Expand Down
18 changes: 9 additions & 9 deletions src/lib/authui/ldapkrb/edit_realm_dialog.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ def dialog_content
VBox(
InputField(Id(:realm_name), Opt(:hstretch), _('Realm name'), @realm_name.to_s),
CheckBox(Id(:map_domain), Opt(:hstretch), _('Map Domain Name to the Realm (example.com -> EXAMPLE.COM)'),
!@realm_name.nil? && !AuthConfInst.krb_conf_get(['domain_realms', @realm_name.downcase], nil).nil?),
!@realm_name.nil? && !AuthConfInst.krb_conf_get(['domain_realm', @realm_name.downcase], nil).nil?),
CheckBox(Id(:map_wildcard_domain), Opt(:hstretch), _('Map Wild Card Domain Name to the Realm (*.example.com -> EXAMPLE.COM)'),
!@realm_name.nil? && !AuthConfInst.krb_conf_get(['domain_realms', ".#{@realm_name.downcase}"], nil).nil?),
!@realm_name.nil? && !AuthConfInst.krb_conf_get(['domain_realm', ".#{@realm_name.downcase}"], nil).nil?),
VSpacing(1.0),
InputField(Id(:admin_server), Opt(:hstretch), _('Host Name of Administration Server (Optional)'),
AuthConfInst.krb_conf_get(['realms', @realm_name, 'admin_server'], '')),
Expand Down Expand Up @@ -142,9 +142,9 @@ def ok_handler
if AuthConfInst.krb_conf['libdefaults']['default_realm'] == @realm_name
AuthConfInst.krb_conf['libdefaults']['default_realm'] = input_realm_name
end
domains = AuthConfInst.krb_conf['domain_realms'].select{ |_, realm| realm == @realm_name}.keys
domains.each {|domain| AuthConfInst.krb_conf['domain_realms'].delete(domain)}
domains.each {|domain| AuthConfInst.krb_conf['domain_realms'][domain] = input_realm_name}
domains = AuthConfInst.krb_conf['domain_realm'].select{ |_, realm| realm == @realm_name}.keys
domains.each {|domain| AuthConfInst.krb_conf['domain_realm'].delete(domain)}
domains.each {|domain| AuthConfInst.krb_conf['domain_realm'][domain] = input_realm_name}
end
# Create new realm
if !AuthConfInst.krb_conf['realms'].include?(input_realm_name)
Expand All @@ -156,14 +156,14 @@ def ok_handler
realm_conf['master_kdc'] = UI.QueryWidget(Id(:master_kdc), :Value)
realm_conf['kdc'] = UI.QueryWidget(Id(:kdc), :Items).map{|item| item[1]}
if UI.QueryWidget(Id(:map_domain), :Value)
AuthConfInst.krb_conf['domain_realms'][input_realm_name.downcase] = input_realm_name
AuthConfInst.krb_conf['domain_realm'][input_realm_name.downcase] = input_realm_name
else
AuthConfInst.krb_conf['domain_realms'].delete(input_realm_name.downcase)
AuthConfInst.krb_conf['domain_realm'].delete(input_realm_name.downcase)
end
if UI.QueryWidget(Id(:map_wildcard_domain), :Value)
AuthConfInst.krb_conf['domain_realms'][".#{input_realm_name.downcase}"] = input_realm_name
AuthConfInst.krb_conf['domain_realm'][".#{input_realm_name.downcase}"] = input_realm_name
else
AuthConfInst.krb_conf['domain_realms'].delete(".#{input_realm_name.downcase}")
AuthConfInst.krb_conf['domain_realm'].delete(".#{input_realm_name.downcase}")
end
realm_conf['auth_to_local'] = UI.QueryWidget(Id(:auth_to_local), :Items).map{|item| item[1]}
realm_conf['auth_to_local_names'] = Hash[*UI.QueryWidget(Id(:auth_to_local_names), :Items).map{|item| [item[1], item[2]]}.flatten]
Expand Down
2 changes: 1 addition & 1 deletion src/lib/authui/ldapkrb/main_dialog.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def ui_event_loop
redo
end
if Popup.YesNo(_('Are you sure to delete realm %s?') % [realm_name])
AuthConfInst.krb_conf['domain_realms'].delete_if{ |_, domain_realm| domain_realm == realm_name}
AuthConfInst.krb_conf['domain_realm'].delete_if{ |_, domain_realm| domain_realm == realm_name}
if UI.QueryWidget(Id(:krb_default_realm), :Value) == realm_name
UI.ChangeWidget(Id(:krb_default_realm), :Value, _('(not specified)'))
end
Expand Down
42 changes: 33 additions & 9 deletions test/authconf_test.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,33 @@
"auth_to_local"=>["RULE:[2:$1](johndoe)s/^.*$/guest/"]
},
},
"domain_realms"=>{}, "logging"=>{}
"domain_realm"=>{}, "logging"=>{}
}, "pam"=>false)
# The second example is very comprehensive
# The second tests for cruft in the section names
authconf.krb_parse_set('
[libdefaultsXXXXXXXXX]
default_realm = ABC.ZZZ
[realmsYYYZZZZXXXXX]
ABC.ZZZ = {
kdc = howie.suse.de
admin_server = howie.suse.de
auth_to_local = RULE:[2:$1](johndoe)s/^.*$/guest/
}
')
expect(authconf.krb_export).to eq("conf"=>{
"include"=>[],
"libdefaults"=>{"default_realm"=>"ABC.ZZZ"},
"realms"=>{
"ABC.ZZZ"=>{
"kdc"=>["howie.suse.de"],
"admin_server"=>"howie.suse.de",
"auth_to_local"=>["RULE:[2:$1](johndoe)s/^.*$/guest/"]
},
},
"domain_realm"=>{}, "logging"=>{}
}, "pam"=>false)
# The third example is very comprehensive
authconf.krb_parse_set('include a/b/c.d
includedir e/f/g.h
module i/j/k.l:RESIDUAL
Expand Down Expand Up @@ -223,7 +247,7 @@ module i/j/k.l:RESIDUAL
EMPTY.NET = {
}
[domain_realms]
[domain_realm]
.suse.de = ABC.ZZZ
suse.de = ABC.ZZZ
Expand Down Expand Up @@ -263,7 +287,7 @@ module i/j/k.l:RESIDUAL
},
"EMPTY.NET"=> {},
},
"domain_realms"=>{".suse.de"=>"ABC.ZZZ", "suse.de"=>"ABC.ZZZ"},
"domain_realm"=>{".suse.de"=>"ABC.ZZZ", "suse.de"=>"ABC.ZZZ"},
"logging"=>{"kdc"=>"FILE:/var/log/krb5/krb5kdc.log", "admin_server"=>"FILE:/var/log/krb5/kadmind.log", "default"=>"SYSLOG:NOTICE:DAEMON"},
"dbmodules"=>{
"openldap_ldapconf"=>{
Expand All @@ -289,7 +313,7 @@ module i/j/k.l:RESIDUAL
forwardable = true
default_ccache_name = FILE:/tmp/krb5cc_%{uid}
[domain_realms]
[domain_realm]
.suse.de = ABC.ZZZ
suse.de = ABC.ZZZ
Expand Down Expand Up @@ -338,7 +362,7 @@ module i/j/k.l:RESIDUAL
{"ABC.ZZZ"=>{"kdc"=>["howie.suse.de"], "admin_server"=>"howie.suse.de"},
"ABD.ZZZ"=>{"kdc"=>["howie2.suse.de"], "admin_server"=>"howie2.suse.de"}},
"libdefaults"=>{"default_realm"=>"ABC.ZZZ", "forwardable"=>"true"},
"domain_realms"=>{".suse.de"=>"ABC.ZZZ", "suse.de"=>"ABC.ZZZ"},
"domain_realm"=>{".suse.de"=>"ABC.ZZZ", "suse.de"=>"ABC.ZZZ"},
"logging"=>
{"kdc"=>"FILE:/var/log/krb5/krb5kdc.log",
"admin_server"=>"FILE:/var/log/krb5/kadmind.log",
Expand All @@ -351,7 +375,7 @@ module i/j/k.l:RESIDUAL
conf = {"conf"=>
{"realms"=>{},
"libdefaults"=>{},
"domain_realms"=>{},
"domain_realm"=>{},
"logging"=>
{"kdc"=>"FILE:/var/log/krb5/krb5kdc.log",
"admin_server"=>"FILE:/var/log/krb5/kadmind.log",
Expand All @@ -363,7 +387,7 @@ module i/j/k.l:RESIDUAL
{"realms"=>
{"ABC.ZZZ"=>{"kdc"=>"howie.suse.de", "admin_server"=>"howie2.suse.de"}},
"libdefaults"=>{"default_realm"=>"ABC.ZZZ"},
"domain_realms"=>{".abc.zzz"=>"ABC.ZZZ", "abc.zzz"=>"ABC.ZZZ"},
"domain_realm"=>{".abc.zzz"=>"ABC.ZZZ", "abc.zzz"=>"ABC.ZZZ"},
"logging"=>
{"kdc"=>"FILE:/var/log/krb5/krb5kdc.log",
"admin_server"=>"FILE:/var/log/krb5/kadmind.log",
Expand All @@ -374,7 +398,7 @@ module i/j/k.l:RESIDUAL
{"realms"=>
{"ABC.ZZZ"=>{"kdc"=>"3.suse.de", "admin_server"=>"4.suse.de"}},
"libdefaults"=>{"default_realm"=>"ABC.ZZZ"},
"domain_realms"=>{},
"domain_realm"=>{},
"logging"=>
{"kdc"=>"FILE:/var/log/krb5/krb5kdc.log",
"admin_server"=>"FILE:/var/log/krb5/kadmind.log",
Expand Down

0 comments on commit 68f8ee1

Please sign in to comment.