Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow command line arguments #52

Merged
merged 3 commits into from
Nov 10, 2018

Conversation

Mathyn
Copy link
Contributor

@Mathyn Mathyn commented Nov 9, 2018

This PR allows users to pass command line arguments when hard resetting the Electron app. This is useful in certain scenarios where you the Electron app is started with extra command line arguments. In such a scenario the arguments should be retained between start ups.

@yan-foto
Copy link
Owner

yan-foto commented Nov 9, 2018

Thanks for the PR 🙏 , I will definitely merge this over the weekend.

By the way: this PR reminds of #50, would you also care to generalize the feature so it also fulfills the requirements of #50? Of course, only if you have the time and interest!

@Mathyn
Copy link
Contributor Author

Mathyn commented Nov 9, 2018

Hi yan-foto, I'll take a look and try to generalize this PR further.

@Mathyn
Copy link
Contributor Author

Mathyn commented Nov 9, 2018

I'm running into some issues with electron-forge. I'm afraid I'm not experienced enough with Electron and Electron Forge to fix these issues right now (just started Electron last week). Could you merge this PR as is?

@yan-foto
Copy link
Owner

yan-foto commented Nov 9, 2018

Yes. I will merge it as is. Give me some time ⌛️

@yan-foto yan-foto merged commit 2cf23ae into yan-foto:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants