Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id type wrong due to no sorted methods from Class.getMethods #620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix id type wrong due to no sorted methods from Class.getMethods #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions elide-core/src/main/java/com/yahoo/elide/core/EntityBinding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,11 @@ private void bindEntityId(Class<?> cls, String type, AccessibleObject fieldOrMet
String fieldName = getFieldName(fieldOrMethod);
Class<?> fieldType = getFieldType(fieldOrMethod);

if (idType != null && fieldType.isAssignableFrom(idType)) {
Copy link
Contributor

@clayreimann clayreimann Jan 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ordering is undefined in the OpenJDK, how can we be sure that we always want the first idType?

This looks like it will cause us to only bind the first field or method annotated with @Id we find and not necessarily the @Id that is closest to the class we are binding.

Also, what does it mean for a JPA annotated bean to have more than 1 field annotated with @Id?

// don't override idType with super class idType
return;
}

//Add id field to type map for the entity
fieldsToTypes.put(fieldName, fieldType);

Expand Down