Add a url option when executing image action #1426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofiachie
approved these changes
May 12, 2018
j0k3r
reviewed
May 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Description of the bug or feature]
when i use execAction('image'), i don't see any options in your guide to put an url to this method.
so i decided to create my own one.
my use case: I handled image from clipboard, upload it to server and response an url, then i show it on medium editor by execAction('image',{url: 'https://mywebsite.com/example.jpg'}).
if you see it useful, you can merge this request.
and if my changed is bad, please improve it and update your readme.md.
Thank.
--