XWIKI-22681: Provide a relative ResourceReferenceEntityReferenceResolver #3673
+1,101
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
commented
Nov 22, 2024
| // TODO: check that this assert is ok, we don't get the default page since we don't have any info to properly | ||
| // resolve the absolute ref (no wiki, no base reference) | ||
| assertEquals(PAGE_ENTITY_REFERENCE, | ||
| this.resolver.resolve(documentResource(SPACE + '.' + PAGE, false), null)); |
There was a problem hiding this comment.
This assertion is probably the first one we should ensure we agree on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22681
TODO
Changes
Description
Clarifications
Screenshots & Video
Executed Tests
Run
mvn clean install -Pqualityon modulexwiki-platform-rendering-xwiki. Now this component implem is used for #3654 so integration tests are executed in that one.Expected merging strategy