Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-16216: Allow users to rebind the shortcuts from their user profile UI #2981

Draft
wants to merge 57 commits into
base: master
Choose a base branch
from

Commits on Feb 23, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Added the parameters in the backend
    * Added a tab with some default content
    
    TODO:
    * Use the backend values when defining shortcuts e.g. in menus_content.vm
    * Add the template to view/edit the values of each options. Note that the organization in XWikiPreferencesDocumentInitializer.java can be used as a skeleton for the architecture of the section.
    * Add translation keys for all the fields
    * Add explanations and a link to xwiki.org doc in the template
    Sereza7 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1d33e79 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Started using the backend values when defining shortcuts e.g. in menus_content.vm
    Sereza7 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e540a4e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Reverted the addition of a category
    Sereza7 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    36df3bf View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated preference sheet and translations
    Sereza7 committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    48d8e87 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Removed unwanted changes from ImageIT
    * Moved the backend preferences from wiki administration to user preferences...
    * Added use of those preferences everywhere where we used some translations
    * Improved the template for the shortcut preferences
    Sereza7 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c6de222 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated some tests, not tested yet...
    Sereza7 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    84e0582 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32ec4c0 View commit details
    Browse the repository at this point in the history
  4. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Improved and fixed tests
    Sereza7 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    37ab413 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    147e445 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed the developer shortcut to use the same kind of shortcut as others... highlighted a limitation of this system
    * Fixed a typo in translation key
    * Added a condition to display view shortcuts only when they are usable (user is advanced).
    Sereza7 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    8c358d7 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed some translations
    Sereza7 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    204252e View commit details
    Browse the repository at this point in the history
  4. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed unwanted change
    Sereza7 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b2ba4c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    3e97dd9 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated tests
    
    TODO: Make sure the changeShortcutInformation test passes. The first one should be good
    Sereza7 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d395e5d View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated tests
    Sereza7 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    bacc686 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated a parameter name to fit the shortcut identifier
    * Matched the edit action button titles with their new shortcuts
    Sereza7 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    124df66 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed code style and imports
    Sereza7 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a04cfbf View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    
    * Updated default translation value
    
    Co-authored-by: Michael Hamann <michael@content-space.de>
    Sereza7 and michitux authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    84a9a1d View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    
    * Updated default translation value
    
    Co-authored-by: Michael Hamann <michael@content-space.de>
    Sereza7 and michitux authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9396c6c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed missing escaping
    Sereza7 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    72af963 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c894b16 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    9ee324b View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    8be9ead View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Refactored the way to get the shortcut values.
    * Tested the new velocity macro in all its application contexts, everything still works properly (there has been issues with newlines instead of an empty result. Moreover testing on a live distrib was a bit of a pain because of caching and javascript bundling).
    Sereza7 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d7fa7e1 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Removed unrelated format changes
    Sereza7 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    83be0b8 View commit details
    Browse the repository at this point in the history
  4. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Removed unrelated format changes
    Sereza7 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3e0960c View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Added escaping to the shortcut Value macro result.
    Sereza7 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    09c3e7d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Started migrating to a XObject implementation
    Sereza7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1b1aac7 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    835b4c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Remove the creation of all the textfields
    * Update the value we look for when trying to get the user preference
    * Take into account the case where the value is empty
    * Update `#displayShortcut` to display placeholders if there's no item that suits the current shortcut.
    * Update the behavior at form submission to create new items for every shortcut that would have a non empty value.
    * Update the translation keys to reflect better their new nature.
    Sereza7 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ca85cc5 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Simplified the shortcut retrieval method by removing an unnecessary argument
    * Added the forgotten .js to the XWikiUserPreferencesSheet.xml
    * Fixed an incorrect empty validation on the form edition arguments.
    Sereza7 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1228086 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated/removed the two places where I used the shortcut preference to change some elements.
    Sereza7 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    101d891 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef8513a View commit details
    Browse the repository at this point in the history
  4. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated doc version number
    Sereza7 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    091679c View commit details
    Browse the repository at this point in the history
  5. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated the XAR to be validated
    Sereza7 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6e3a355 View commit details
    Browse the repository at this point in the history
  6. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated the XAR to be validated
    Sereza7 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    74ffe8e View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed the view display when the shortcut preference is empty.
    Sereza7 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fa9d562 View commit details
    Browse the repository at this point in the history
  2. Update xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-pr…

    …ofile/xwiki-platform-user-profile-ui/src/main/resources/XWiki/XWikiUserPreferencesSheet.xml
    
    
    * Fixed codestyle
    
    Co-authored-by: Michael Hamann <michael@content-space.de>
    Sereza7 and michitux authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    bc3af80 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    
    * Fixed codestyle
    
    Co-authored-by: Michael Hamann <michael@content-space.de>
    Sereza7 and michitux authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6bb5cf7 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    754813c View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed the escaping strategy
    --> tested all the categories of shortcuts, they all work properly
    Sereza7 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    74f90d2 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Escaped value
    Sereza7 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    67e337c View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. XWIKI-22280: Object editor dropdowns are not keyboard accessible

    * Added a flex layout for view and edit mode
    * Removed the useless hints
    TODO:
    * Some more styling
    * Edition of multiple fields quickly is buggy? See XWikiUserPreferencesSheet L180
    Sereza7 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    45dcafa View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed some bugs for multiple field edition quickly
    TODO:
    * Some more styling for the view mode
    Sereza7 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2d2757c View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Added an indication for unbound shortcuts in the view mode
    Sereza7 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    26dfb55 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Added a margin between the hint and the list of shortcut preferences
    * Escaped characters for XML
    Sereza7 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b67ddc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Improved performance of the shortcut preference retrieval
    Sereza7 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bbc63a0 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Improved preference UI mostly for the view mode.
    Sereza7 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fbcd0f6 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Reverted the boldness changes
    Sereza7 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    031d727 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    2b2ac2e View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed a bug caused by the recent change of the getShortcutValue macro in actionButtons.js.
    * Created the map of shortcuts directly in velocity and serialized it directly to JSON.
    Sereza7 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    150f1e6 View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated the style to be a bit more specific
    Sereza7 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    72e7f89 View commit details
    Browse the repository at this point in the history
  4. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Updated comment
    Sereza7 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    90f8096 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed the extra tabs shortcuts implementation
    Sereza7 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ac1e5f6 View commit details
    Browse the repository at this point in the history
  2. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    * Fixed the case on the custom data fields (velocity template and js>jquery that relies on it)
    Sereza7 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9b4344c View commit details
    Browse the repository at this point in the history
  3. XWIKI-16216: Allow users to rebind the shortcuts from their user prof…

    …ile UI
    
    
    * Added a space between the shortcut value and the `(Default)` hint that would be displayed next to it when it has the default value.
    
    Co-authored-by: Michael Hamann <michael@content-space.de>
    Sereza7 and michitux authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    53b57b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    3edd13a View commit details
    Browse the repository at this point in the history