Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21894: JSC_PARSE_ERROR in Tour.WebHome #2914

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Feb 20, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21894

Changes

Description

  • Added proper escaping to the icon

Clarifications

  • The icon was not escaped, which explains the fail. The previous commit fixed the error, but didn't tackle the root cause.

Executed Tests

Manual tests. Changes are not about front-end API.

Expected merging strategy

@surli surli added backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.1.x labels Feb 20, 2024
* Added proper escaping to the icon
@surli surli merged commit fb2cfcf into xwiki:master Feb 20, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
* Added proper escaping to the icon

(cherry picked from commit fb2cfcf)
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
* Added proper escaping to the icon

(cherry picked from commit fb2cfcf)
surli pushed a commit that referenced this pull request Feb 20, 2024
* Added proper escaping to the icon

(cherry picked from commit fb2cfcf)
surli pushed a commit that referenced this pull request Feb 20, 2024
* Added proper escaping to the icon

(cherry picked from commit fb2cfcf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants