XWIKI-21864: Menu Application: If list element is a link, the xDropdown-header-toggle drops to a new line and other weirdness #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn-header-toggle drops to a new line and other weirdness * Fixed incorrect padding on link section headers in the submenus * Positioned the toggle absolutely in those sections so that it doesn't eat away at space the text had before and force a linebreak where there used to be none.
|
Waiting for user feedback on UI changes before opening this PR for code review. See https://forum.xwiki.org/t/menu-macro-changed-lts-14-10-20-to-15-10-5/14072/8?u=charpentierlucas |
|
Feedback from users seems to be positive. Opening the PR for code review. |
Sereza7
added
the
backport stable-15.10.x
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
…wn-header-toggle drops to a new line and other weirdness (#2893) * Fixed incorrect padding on link section headers in the submenus * Positioned the toggle absolutely in those sections so that it doesn't eat away at space the text had before and force a linebreak where there used to be none. (cherry picked from commit 6526e78)
michitux
pushed a commit
that referenced
this pull request
Feb 16, 2024
…wn-header-toggle drops to a new line and other weirdness (#2893) (#2900) * Fixed incorrect padding on link section headers in the submenus * Positioned the toggle absolutely in those sections so that it doesn't eat away at space the text had before and force a linebreak where there used to be none. (cherry picked from commit 6526e78) Co-authored-by: Lucas C <lucas.charpentier@imt-atlantique.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21864
Changes
Description
Clarifications
Screenshots & Video
Manual tests video demo: https://youtu.be/QU14vb_BkV4
Executed Tests
Only manual (see video). This is an extra patch upon the changes in https://github.com/xwiki/xwiki-platform/pull/2078/files which did not fail any build.
Moreover, this patch is style only so I doubt it could break any test.
Expected merging strategy