Skip to content

Commit

Permalink
XWIKI-21894: JSC_PARSE_ERROR in Tour.WebHome (#2895)
Browse files Browse the repository at this point in the history
Use double quotes for icon aria-hidden value

The single quotes leads to error for example with tour extension:
```
xwiki:Tour.WebHome:17:78: ERROR - [JSC_PARSE_ERROR] Parse error. ',' expected
  17|       $('<a class="action actionLaunch"><span class="fa fa-play" aria-hidden='true'></span> Launch</a>')
                                                                                    ^
1 error(s), 0 warning(s)
```

(cherry picked from commit 3fe9ffe)
  • Loading branch information
amottier authored and surli committed Feb 20, 2024
1 parent 013019d commit 7317a62
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
<content>## General settings
xwiki.iconset.type = font
xwiki.iconset.css = $services.webjars.url('org.webjars:font-awesome', 'css/font-awesome.min.css')
xwiki.iconset.render.wiki = {{html clean="false"}}&lt;span class="fa fa-$icon" aria-hidden='true'&gt;&lt;/span&gt;{{/html}}
xwiki.iconset.render.html = &lt;span class="fa fa-$icon" aria-hidden='true'&gt;&lt;/span&gt;
xwiki.iconset.render.wiki = {{html clean="false"}}&lt;span class="fa fa-$icon" aria-hidden="true"&gt;&lt;/span&gt;{{/html}}
xwiki.iconset.render.html = &lt;span class="fa fa-$icon" aria-hidden="true"&gt;&lt;/span&gt;
xwiki.iconset.icon.cssClass = fa fa-$icon

## XWiki Icon Set (see: http://design.xwiki.org/xwiki/bin/view/Proposal/XWiki+Icon+Set).
Expand Down

0 comments on commit 7317a62

Please sign in to comment.