Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax tolerance in the xlapack.solveCholesky test #212

Commits on Oct 16, 2021

  1. relax tolerance in the xlapack.solveCholesky test

    The xlapack.solveCholesky test in test_lapack.cpp fails on 32-bit architectures (i386/i686):
    [ RUN      ] xlapack.solveCholesky
    /tmp/autopkgtest-lxc.gg3nslld/downtmp/autopkgtest_tmp/test_lapack.cpp:166: Failure
    Expected equality of these values:
      x_expected[i]
        Which is: 0.13757507429403265
      x[i]
        Which is: 0.13757507429403248
    [  FAILED  ] xlapack.solveCholesky (0 ms)
    
    This patch relaxes test tolerance by using EXPECT_NEAR with abstol=2e-16 instead of EXPECT_DOUBLE_EQ.
    
    Fixes Issue xtensor-stack#211.
    drew-parsons authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    4a2eb67 View commit details
    Browse the repository at this point in the history
  2. relax solveCholesky test tolerance further (for armhf)

    The armhf discrepancy is coarser, 0.13757507429403265 - 0.13757507429403243 = 2.220446049250313e-16
    
    So relax test tolerance to 5e-16.
    drew-parsons authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    fd24ac0 View commit details
    Browse the repository at this point in the history