New method to detect TOFF runway #463
Open
+174
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoolive
requested changes
Oct 9, 2024
| @@ -2589,6 +2592,119 @@ def intersects( # type: ignore | |||
| # given here for consistency in types | |||
| ... | |||
|
|
|||
| def get_toff_runway( | |||
There was a problem hiding this comment.
can we reuse takeoff_from_runway but pass an argument (string) with the method which can come to this one? would be more helpful to understand why we need two methods
There was a problem hiding this comment.
I find it a bit confusing because it does not return an iterable while takeoff_from_runway does
|
Also please consider adding a test 🙇♂️ |
|
Should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people in Winterthur wanted a function to detect the toff runway so here is an attempt that seems to be working reasonably.
It serves a different purpose than the
takeoff_from_runwayfunction.