Split package publish and changelog publish #60
+48
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoofx
reviewed
May 20, 2024
| @@ -32,9 +33,6 @@ public partial class ReleaserApp | |||
| { | |||
| var appPackagesToPublish = buildPackageInformation.AppPackages; | |||
|
|
|||
| // In the case of a build, we still want to upload a draft release notes | |||
There was a problem hiding this comment.
But in that case, it doesn't upload anymore the packages here no? That would require to split devHosting.UpdateChangelogAndUploadPackages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #53
Check #53 for more details and context.
I'm not sure that this is the best way to achieve a goal. This PR is more about getting feedback. Is this good idea to split these two actions?