Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about VCF format conversion #92

Open
yuxizhang01 opened this issue Dec 5, 2023 · 3 comments
Open

A question about VCF format conversion #92

yuxizhang01 opened this issue Dec 5, 2023 · 3 comments

Comments

@yuxizhang01
Copy link

I am a master's student studying plants and VCF format is a commonly used SNP format for me. I use this command to processing my data :
image
After the phenotype is added, an additional file of the phenotype is output. The output phenotype file is not in the same order as my original phenotype file. After I checked it, it seemed that in subsequent GWAS analyses, it seemed that the output phenotype file had to be used instead of my original phenotype file. But this is not emphasized in your ReadMe. I would like to ask what is the reason for this?
And by the way, in the given command, the row that adds the phenotype is commented out, but shouldn't the line that adds the phenotype be important?
Thank you very much for answering my questions!!!

@YinLiLin
Copy link
Collaborator

YinLiLin commented Dec 6, 2023

Thank you for the question.
Yes, if the phenotype file is provided, rMVP will automatically re-order the individuals in phenotype file to be consistent with that in genotype file, we recommend providing phenotype file since it can help users avoid some potential problems. However, it's not mandatory, because some users are only interested in parts of functions in rMVP, e.g., genotype numeric coding, PCA and Kinship calculation, in which the phenotype file is not involved. Therefore we command out this line in the tutorial script to tell the users that the phenotype file is optional, it does not represent unimportance.

@yuxizhang01
Copy link
Author

Thank you for your answer
The reason I asked this question was because in the subsequent GWAS analysis, the phenotype file I provided is the original one, not a reorganized version, leading to consistent issues with the results. I think you can mention this in the README of GWAS analysis, maybe it will be more comprehensive!

@YinLiLin
Copy link
Collaborator

YinLiLin commented Dec 8, 2023

Thank you for the valuable suggestion. We have added descriptions at corresponding position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants