Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28453567 #21

Merged
merged 7 commits into from
Feb 28, 2024
Merged

28453567 #21

merged 7 commits into from
Feb 28, 2024

Conversation

adremp
Copy link
Collaborator

@adremp adremp commented Feb 14, 2024

No description provided.

@adremp adremp self-assigned this Feb 14, 2024
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xieffect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 7:38pm

Copy link
Contributor

@unknownproperty unknownproperty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тоже самое и для второй модалки

@@ -18,6 +18,8 @@
"pkg.navigation.layout": "*",
"pkg.module.videoconference": "*",
"pkg.navigation.skeleton": "*",
"pkg.modal.change-password": "*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это лишнее, так как мы подключаем пакеты к другому пакету


return (
<M.Modal>
<M.ModalTrigger asChild>{props.children}</M.ModalTrigger>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А может быть уберём props и развернём объект пропсов?

interface FormBlockProps {}

const FormBlock = (props: FormBlockProps) => {
const form = useForm<z.infer<typeof schema>>({ resolver: zodResolver(schema) });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь, пожалуйста, изменения из @xipkg/form

"@xipkg/label": "0.0.9",
"@xipkg/link": "0.2.0",
"@xipkg/utils": "1.0.1",
"next": "^14.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

версия 13.5.6

"@xipkg/utils": "1.0.1",
"next": "^14.0.4",
"react": "^18.2.0",
"react-hook-form": "^7.45.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это можно удалить

Copy link
Contributor

@unknownproperty unknownproperty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, смёржил

@unknownproperty unknownproperty merged commit a021a57 into staging Feb 28, 2024
6 checks passed
@adremp adremp deleted the 28453567 branch April 3, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants