Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable recursive ISOSR scanning #469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imakiro
Copy link

@imakiro imakiro commented Dec 1, 2019

This change from ls to find enable a simple recursion control.

@coveralls
Copy link

coveralls commented Dec 1, 2019

Coverage Status

Coverage remained the same at 37.237% when pulling fd9e523 on imakiro:ISOSR-recursive-search into 8ca9de0 on xapi-project:master.

@imakiro imakiro force-pushed the ISOSR-recursive-search branch 3 times, most recently from 8cc7823 to c1572a4 Compare December 1, 2019 04:05
Replacing ls command by find
Signed-off-by: imakiro <pj2000@hotmail.fr>
@MarkSymsCtx
Copy link
Contributor

I think there are good reasons why we would not want this to be enabled by default given the significant change in behaviour.

@imakiro
Copy link
Author

imakiro commented Dec 16, 2019

I think there are good reasons why we would not want this to be enabled by default given the significant change in behaviour.

This seemed like a good idea, do you mind explaining which element is impacted significantly ? using a sane default of 1 would simply present the same behaviour as right now.

@Nick-085
Copy link

Is this something that can be reviewed again? I'm trying not to present every path on my TrueNAS to the network. I already have too many.

@olivierlambert
Copy link

@Nick-085 have you tried the modifications? It might be easy to test, and having more feedback might help the upstream to be more confident on merging this at some point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants