CA-210336: Added exception handling to prevent stack trace dump #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivers/BaseISCSI.py
Outdated
| devs_path = "/dev/disk/by-scsid/%s" % self.dconf['SCSIid'] | ||
| devs = os.listdir(devs_path) | ||
| except: | ||
| util.SMlog("[Errno 2] No such file or directory: '%s'" % devs_path) |
There was a problem hiding this comment.
What happens after the exception is handled here, the code blindly continues which is probably not what we want here.
There was a problem hiding this comment.
@MarkSymsCtx I have raised a XenError exception and the most accurate error code I could find for this exception is the one I pasted below. Does that look right?
<code> <name>ConfigDeviceInvalid</name> <description>The device is not a valid path</description> <value>91</value> </code>
letsboogey
force-pushed
the
CA-210336
branch
2 times, most recently
from
5df738f
to
5c1552f
Compare
|
Changes Unknown when pulling 5c1552f on letsboogey:CA-210336 into * on xapi-project:master*. |
Added exception handling for when devices path is not valid. Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
|
Changes Unknown when pulling 841e50f on letsboogey:CA-210336 into * on xapi-project:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exception handling for when devices path is not valid.
Signed-off-by: Letsibogo Ramadi letsibogo.ramadi@citrix.com