Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v0.7.3 #712

Merged
merged 11 commits into from
Nov 6, 2024
Merged

Bump to v0.7.3 #712

merged 11 commits into from
Nov 6, 2024

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Nov 6, 2024

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder changed the title Update numpy constraint to <3.0.0 in conda envs Bump to v0.7.3 Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b1a72fc) to head (a126a32).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #712   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1555      1555           
=========================================
  Hits          1555      1555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the type: docs Updates to documentation label Nov 6, 2024
@tomvothecoder tomvothecoder marked this pull request as ready for review November 6, 2024 18:23
pyproject.toml Outdated
Comment on lines 1 to 32
[build-system]
requires = ["setuptools>=42", "wheel"]
build-backend = "setuptools.build_meta"

[project]
name = "xcdat"
version = "0.7.3"
description = "Xarray Climate Data Analysis Tools"
readme = "README.rst"
requires-python = ">=3.9"
license = { text = "Apache-2.0" }
authors = [{ name = "xCDAT developers" }]
classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache-2.0 License",
"Natural Language :: English",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]
keywords = ["xcdat"]
dependencies = []

[project.optional-dependencies]
test = ["pytest>=3"]

[tool.setuptools.packages.find]
include = ["xcdat", "xcdat.*"]

Copy link
Collaborator Author

@tomvothecoder tomvothecoder Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xylar, I'm moving from setup.py to pyproject.toml for xCDAT. How does this look? And anything else I need to do on the conda-forge side?

@tomvothecoder tomvothecoder self-assigned this Nov 6, 2024
@tomvothecoder tomvothecoder added the patch A patch release, includes backwards compatible bug fixes. label Nov 6, 2024
pyproject.toml Outdated
"Programming Language :: Python :: 3.12",
]
keywords = ["xcdat"]
dependencies = []
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. My only comment is that it can be advantageous to add all the runtime dependencies that are also available on PyPI here. This allows you to use pip check both here and on the conda-forge feedstock. But it also requires updating dependencies in 2 places.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added your suggestion, thanks.

pyproject.toml Outdated

[project]
name = "xcdat"
version = "0.7.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added your suggestion, thanks.

tbump.toml Outdated Show resolved Hide resolved
@tomvothecoder tomvothecoder merged commit 1cfd369 into main Nov 6, 2024
5 checks passed
@tomvothecoder tomvothecoder deleted the bump/v0.7.3 branch November 6, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A patch release, includes backwards compatible bug fixes. type: docs Updates to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants