-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v0.7.3 #712
Bump to v0.7.3 #712
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1555 1555
=========================================
Hits 1555 1555 ☔ View full report in Codecov by Sentry. |
2350ded
to
010b6f3
Compare
pyproject.toml
Outdated
[build-system] | ||
requires = ["setuptools>=42", "wheel"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "xcdat" | ||
version = "0.7.3" | ||
description = "Xarray Climate Data Analysis Tools" | ||
readme = "README.rst" | ||
requires-python = ">=3.9" | ||
license = { text = "Apache-2.0" } | ||
authors = [{ name = "xCDAT developers" }] | ||
classifiers = [ | ||
"Development Status :: 5 - Production/Stable", | ||
"Intended Audience :: Developers", | ||
"License :: OSI Approved :: Apache-2.0 License", | ||
"Natural Language :: English", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
] | ||
keywords = ["xcdat"] | ||
dependencies = [] | ||
|
||
[project.optional-dependencies] | ||
test = ["pytest>=3"] | ||
|
||
[tool.setuptools.packages.find] | ||
include = ["xcdat", "xcdat.*"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @xylar, I'm moving from setup.py
to pyproject.toml
for xCDAT. How does this look? And anything else I need to do on the conda-forge side?
pyproject.toml
Outdated
"Programming Language :: Python :: 3.12", | ||
] | ||
keywords = ["xcdat"] | ||
dependencies = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. My only comment is that it can be advantageous to add all the runtime dependencies that are also available on PyPI here. This allows you to use pip check
both here and on the conda-forge feedstock. But it also requires updating dependencies in 2 places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added your suggestion, thanks.
pyproject.toml
Outdated
|
||
[project] | ||
name = "xcdat" | ||
version = "0.7.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to make this dynamic:
https://github.com/E3SM-Project/mache/blob/main/pyproject.toml#L74-L75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added your suggestion, thanks.
Description
>=2.0.0,<=3.0.0
#711 (fixes numpy constraint ->numpy >=2.0.0,<3.0.0
)setup.py
withpyproject.toml
Checklist
If applicable: