fix: Uses consistent verbs to close #338. (#340 - Thanks @garemoko)

BREAKING CHANGE: Statements with `http://id.tincanapi.com/verb/completed` changed to `http://adlnet.gov/expapi/verbs/completed`. Changes `core/course_completed` and `core/course_module_completion_updated`. BREAKING CHANGE: Statements with `http://id.tincanapi.com/verb/submitted` changed to `http://activitystrea.ms/schema/1.0/submit`. Changes `mod_feedback/response_submitted`.
xAPI-vle · Dec 7, 2018 · f3a94ce · f3a94ce
1 parent f3d74c6
commit f3a94ce
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 12 deletions.
diff --git a/src/transformer/events/core/course_completed.php b/src/transformer/events/core/course_completed.php
@@ -29,7 +29,7 @@ function course_completed(array $config, \stdClass $event) {
     return [[
         'actor' => utils\get_user($config, $user),
         'verb' => [
-            'id' => 'http://id.tincanapi.com/verb/completed',
+            'id' => 'http://adlnet.gov/expapi/verbs/completed',
             'display' => [
                 $lang => 'completed'
             ],

diff --git a/src/transformer/events/core/course_module_completion_updated.php b/src/transformer/events/core/course_module_completion_updated.php
@@ -32,7 +32,7 @@ function course_module_completion_updated(array $config, \stdClass $event) {
     return [[
         'actor' => utils\get_user($config, $user),
         'verb' => [
-            'id' => 'http://id.tincanapi.com/verb/completed',
+            'id' => 'http://adlnet.gov/expapi/verbs/completed',
             'display' => [
                 $lang => 'completed'
             ],

diff --git a/src/transformer/events/mod_feedback/response_submitted/response_submitted.php b/src/transformer/events/mod_feedback/response_submitted/response_submitted.php
@@ -31,7 +31,7 @@ function response_submitted(array $config, \stdClass $event) {
     return [[
         'actor' => utils\get_user($config, $user),
         'verb' => [
-            'id' => 'http://id.tincanapi.com/verb/submitted',
+            'id' => 'http://activitystrea.ms/schema/1.0/submit',
             'display' => [
                 $lang => 'submitted'
             ],

diff --git a/tests/core/course_completed/completing_existing_course/statements.json b/tests/core/course_completed/completing_existing_course/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/completed",
+            "id": "http:\/\/adlnet.gov\/expapi\/verbs\/completed",
             "display": {
                 "en": "completed"
             }

diff --git a/tests/core/course_module_completion_update/completing_existing_module/statements.json b/tests/core/course_module_completion_update/completing_existing_module/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/completed",
+            "id": "http:\/\/adlnet.gov\/expapi\/verbs\/completed",
             "display": {
                 "en": "completed"
             }

diff --git a/tests/mod_feedback/response_submitted/multichoice/statements.json b/tests/mod_feedback/response_submitted/multichoice/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/submitted",
+            "id": "http:\/\/activitystrea.ms\/schema\/1.0\/submit",
             "display": {
                 "en": "submitted"
             }

diff --git a/tests/mod_feedback/response_submitted/multichoicerated/statements.json b/tests/mod_feedback/response_submitted/multichoicerated/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/submitted",
+            "id": "http:\/\/activitystrea.ms\/schema\/1.0\/submit",
             "display": {
                 "en": "submitted"
             }

diff --git a/tests/mod_feedback/response_submitted/no_items/statements.json b/tests/mod_feedback/response_submitted/no_items/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/submitted",
+            "id": "http:\/\/activitystrea.ms\/schema\/1.0\/submit",
             "display": {
                 "en": "submitted"
             }

diff --git a/tests/mod_feedback/response_submitted/numerical/statements.json b/tests/mod_feedback/response_submitted/numerical/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/submitted",
+            "id": "http:\/\/activitystrea.ms\/schema\/1.0\/submit",
             "display": {
                 "en": "submitted"
             }

diff --git a/tests/mod_feedback/response_submitted/textarea/statements.json b/tests/mod_feedback/response_submitted/textarea/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/submitted",
+            "id": "http:\/\/activitystrea.ms\/schema\/1.0\/submit",
             "display": {
                 "en": "submitted"
             }

diff --git a/tests/mod_feedback/response_submitted/textfield/statements.json b/tests/mod_feedback/response_submitted/textfield/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/submitted",
+            "id": "http:\/\/activitystrea.ms\/schema\/1.0\/submit",
             "display": {
                 "en": "submitted"
             }

diff --git a/tests/mod_feedback/response_submitted/unknown_typ/statements.json b/tests/mod_feedback/response_submitted/unknown_typ/statements.json
@@ -8,7 +8,7 @@
             }
         },
         "verb": {
-            "id": "http:\/\/id.tincanapi.com\/verb\/submitted",
+            "id": "http:\/\/activitystrea.ms\/schema\/1.0\/submit",
             "display": {
                 "en": "submitted"
             }