Remove unified memory #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to add XC_FLAGS_NEEDS_TAU back in See merge request libxc/libxc!642
|
@susilehtola This PR tries to remove the usage of unified memory in libxc. I made this changes for two reasons
Here are the related issues in GPU4PySCF |
|
I think you meant to file a pull request against libxc. |
|
@susilehtola Right. Since there are some changes in data structure and functional kernels, I wanted to have your early evaluation. |
|
The change history is also junk, please rebase to libxc devel branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.