Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc (fix): Use lazy val for generated RPCMethod to avoid xxxInternals$.<clinit> is too large error #3155

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 24, 2023

This error happened in Scala 3 when compiling a RPC client for a large API

@github-actions github-actions bot added bug internal Internal changes (usually non-user facing) labels Aug 24, 2023
@xerial xerial removed the internal Internal changes (usually non-user facing) label Aug 24, 2023
@xerial xerial enabled auto-merge (squash) August 24, 2023 05:57
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #3155 (9afaf29) into main (45198a1) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3155   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files         350      350           
  Lines       14743    14743           
  Branches     2447     2447           
=======================================
  Hits        12219    12219           
  Misses       2524     2524           
Files Changed Coverage Δ
...frame/http/codegen/client/RPCClientGenerator.scala 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ab427...9afaf29. Read the comment docs.

@xerial xerial merged commit 7a43f51 into main Aug 24, 2023
17 checks passed
@xerial xerial deleted the lazy-rpc-method branch August 24, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant