Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to secondary user scenarios #40

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

imesh94
Copy link
Contributor

@imesh94 imesh94 commented Nov 8, 2024

Improvements to secondary user scenarios

In OB2 auth flow, secondary accounts are shown as selectable to any user if they are present in the sharable accounts response. But in OB3, we check the ACCOUNT_METADATA table for 'active' status even if the account is present. This PR introduces a new config to switch between the OB3 default behavior and OB2 behavior for secondary accounts.

In addition, this PR also fixes the issue where secondary user permission is not added in OB_CONSENT_MAPPING table when only secondary accounts are selected.

Issue link: wso2/financial-services-accelerator#190, wso2/financial-services-accelerator#191

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)


Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

@imesh94 imesh94 added the Ready-to-Build Adding this label will trigger a new build job. label Nov 8, 2024
@Akila94 Akila94 merged commit e4d3d74 into wso2:main Nov 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Build Adding this label will trigger a new build job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants