Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consent revocation data not getting published #26

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

imesh94
Copy link
Contributor

@imesh94 imesh94 commented Oct 28, 2024

Fix consent revocation data not getting published

We use request_uri as an event identifier to avoid publishing multiple events for a single consent in consent authorization flow. But if the same request_uri is present in the queue in consent revocation, that event won't be published. This PR is to modify event identifier in the format request_uri:event_type so we can identify multiple event types for a single request_uri uniquely.

Issue link: wso2/financial-services-accelerator#151

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)


Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

@imesh94 imesh94 added the Ready-to-Build Adding this label will trigger a new build job. label Oct 28, 2024
@aka4rKO aka4rKO merged commit ef576f1 into wso2:main Oct 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Build Adding this label will trigger a new build job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants