Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDBC 라이브러리 구현하기 - 4단계] 베베(최원용) 미션 제출합니다. #590

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

wonyongChoi05
Copy link
Member

안녕하세요 후추.. 어제 밤에 구현해놓고 제출을 안하고 있었네요 ㅋㅋㅋㅋㅋㅋ 늦은 제출 정말 죄송합니다 ㅠ 마지막 리뷰 잘 부탁드려요!

Copy link

@Combi153 Combi153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 베베

리뷰가 매우 늦어져 죄송합니다ㅠ

미션의 요구사항은 충분히 만족하신 것 같아요 👍

다만, 베베의 생각이 궁금한 점이 있어 RC 남깁니다.

커멘트에 답변만 달아주시면 바로 머지할게요!

Comment on lines +23 to +28
Map<DataSource, Connection> resource = resources.get();
if (resource == null) {
resource = new HashMap<>();
resources.set(resource);
}
resource.put(key, value);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도한 대로 동작하는지 확인하기 위해 테스트가 필요하지 않을까요?

Copy link

@Combi153 Combi153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 베베~

같이 리뷰 나눌 수 있어서 즐겁고 좋았어요!

덕분에 많이 배웠습니다 😀

남은 기간 화이팅입니다 👍

@Combi153 Combi153 merged commit 2cc0bf5 into woowacourse:wonyongchoi05 Oct 12, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants