fix: 사용량 통계 부분 렌더링을 개선한다 #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feb-dain
added
🚑 버그
gabrielyoon7
approved these changes
Oct 16, 2023
kyw0716
requested changes
Oct 16, 2023
| @@ -53,7 +53,7 @@ const StationDetailsView = ({ station }: StationDetailsViewProps) => { | |||
|
|
|||
| <ChargerList chargers={chargers} stationId={stationId} reportCount={reportCount} /> | |||
|
|
|||
| <CongestionStatistics stationId={stationId} /> | |||
| <CongestionStatistics stationId={stationId} chargers={chargers} /> | |||
There was a problem hiding this comment.
chargers를 리액트 쿼리에서 직접 가져오는 것은 어떤가요?! 나중에 CongestionStatistics 컴포넌트를 독립적으로 사용하게 되는 경우엔 chagers를 컴포넌트 내부에서 가져오는 것이 더 좋을 것 같다는 생각이 드네요!
|
|
||
| import type { Charger } from '@type'; | ||
|
|
||
| export const getChargerCountsAndAvailability = (chargers: Charger[]) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🕰️ Actual Time of Completion
🙋🏻 More
close #863
🚀 Storybook