Fix fatal error in purchasing a subscription with PRB and ECE when the subscription's price or sign-up fee is a string #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayisha
requested review from
a team and
wjrosa
and removed request for
a team
wjrosa
reviewed
Nov 21, 2024
wjrosa
reviewed
Nov 22, 2024
| @@ -366,16 +366,16 @@ public function get_button_label() { | |||
| * @since 5.2.0 | |||
| * | |||
| * @param object $product WC_Product_* object. | |||
| * @return integer Total price. | |||
| * @return float Total price. | |||
| */ | |||
| public function get_product_price( $product ) { | |||
| $product_price = $product->get_price(); | |||
There was a problem hiding this comment.
Suggested change
| $product_price = $product->get_price(); | |
| $product_price = (float) $product->get_price(); |
wjrosa
reviewed
Nov 22, 2024
| } | ||
|
|
||
| return $product_price; | ||
| return (float) $product_price; |
There was a problem hiding this comment.
Suggested change
| return (float) $product_price; | |
| return $product_price; |
wjrosa
reviewed
Nov 22, 2024
| */ | ||
| public function get_product_price( $product ) { | ||
| $product_price = $product->get_price(); | ||
| // Add subscription sign-up fees to product price. | ||
| if ( in_array( $product->get_type(), [ 'subscription', 'subscription_variation' ] ) && class_exists( 'WC_Subscriptions_Product' ) ) { | ||
| $product_price = $product->get_price() + WC_Subscriptions_Product::get_sign_up_fee( $product ); | ||
| $product_price = (float) $product_price + (float) WC_Subscriptions_Product::get_sign_up_fee( $product ); |
There was a problem hiding this comment.
Suggested change
| $product_price = (float) $product_price + (float) WC_Subscriptions_Product::get_sign_up_fee( $product ); | |
| $product_price += (float) WC_Subscriptions_Product::get_sign_up_fee( $product ); |
wjrosa
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2966
In
get_product_pricefunction for PRB/ECE we need$product->get_price(),wc_get_price_including_tax,wc_get_price_excluding_tax,WC_Subscriptions_Product::get_sign_up_feefor different scenarios. These functions may return the result in different types as per the corresponding function definitionsint/float/string.When the types are different the following code causes a fatal error-
Changes proposed in this Pull Request:
floatto avoid the fatal error.Testing instructions